From 1b336f3cccd59d622e8f7f54b46f0d6fac763974 Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Wed, 6 Oct 2021 17:28:03 +0200 Subject: [PATCH] firewall - CARP defaults. our default has always been to allow carp unconditional, which currently doesn't seem to make sense changing. However the "block carp from self" rule was translated incorrectly when changing our plugin structure and doesn't seem to be that useful at all (anymore). This commit removes the rule, which originated from https://github.com/pfsense/pfsense/commit/986a3accd40a7d45c0a3d48d2b42d2c58a231d99 (https://forum.opnsense.org/index.php?topic=25019.msg120273#msg120273) --- src/etc/inc/filter.lib.inc | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/etc/inc/filter.lib.inc b/src/etc/inc/filter.lib.inc index d9a3aa68b..76985d8fc 100644 --- a/src/etc/inc/filter.lib.inc +++ b/src/etc/inc/filter.lib.inc @@ -275,13 +275,6 @@ function filter_core_rules_system($fw, $defaults) ); } // CARP defaults - $carp_disabled = empty($config['hasync']) && empty($config['virtualip']['vip']); - $fw->registerFilterRule( - 1, - array('protocol' => 'carp', 'descr' => 'CARP defaults', '#ref' => 'system_hasync.php', - 'from' => '(self)', 'direction' => 'in', 'disabled' => !$carp_disabled), - $defaults['block'] - ); $fw->registerFilterRule( 1, array('protocol' => 'carp', 'direction' => 'any', 'descr' => 'CARP defaults', '#ref' => 'firewall_virtual_ip.php'),