diff --git a/src/etc/inc/filter.inc b/src/etc/inc/filter.inc index a3fe8c3d6..9beeb471f 100644 --- a/src/etc/inc/filter.inc +++ b/src/etc/inc/filter.inc @@ -100,14 +100,13 @@ function flowtable_configure() { } } -function filter_pflog_start($kill_first = false) +function filter_pflog_start() { - global $config, $g; - - if (!file_exists("{$g['varrun_path']}/filterlog.pid") || - !isvalidpid("{$g['varrun_path']}/filterlog.pid")) { - mwexec("/usr/local/sbin/filterlog -i pflog0 -p {$g['varrun_path']}/filterlog.pid"); + if (isvalidpid('/var/run/filterlog.pid')) { + return; } + + mwexec('/usr/local/sbin/filterlog -i pflog0 -p /var/run/filterlog.pid'); } /* reload filter async */ @@ -321,31 +320,32 @@ function filter_configure_sync($delete_states_if_needed = true) } # If we are not using bogonsv6 then we can remove any bogonsv6 table from the running pf (if the table is not there, the kill is still fine). - if (!is_bogonsv6_used()) - $_grbg = exec("/sbin/pfctl -t bogonsv6 -T kill 2>/dev/null"); + if (!is_bogonsv6_used()) { + $_grbg = exec('/sbin/pfctl -t bogonsv6 -T kill 2>/dev/null'); + } update_filter_reload_status(gettext("Starting up layer7 daemon")); layer7_start_l7daemon(); - if(!empty($filterdns)) { - @file_put_contents("{$g['varetc_path']}/filterdns.conf", implode("", $filterdns)); + if (!empty($filterdns)) { + @file_put_contents('/var/etc/filterdns.conf', implode('', $filterdns)); unset($filterdns); - if (isvalidpid("{$g['varrun_path']}/filterdns.pid")) { - killbypid("{$g['varrun_path']}/filterdns.pid", 'HUP'); + if (isvalidpid('/var/run/filterdns.pid')) { + killbypid('/var/run/filterdns.pid', 'HUP'); } else { /* * FilterDNS has three debugging levels. The default choosen is 1. * Availabe are level 2 and greater then 2. */ - if (isset($config['system']['aliasesresolveinterval']) && is_numeric($config['system']['aliasesresolveinterval'])) + if (isset($config['system']['aliasesresolveinterval']) && is_numeric($config['system']['aliasesresolveinterval'])) { $resolve_interval = $config['system']['aliasesresolveinterval']; - else + } else { $resolve_interval = 300; - mwexec("/usr/local/sbin/filterdns -p {$g['varrun_path']}/filterdns.pid -i {$resolve_interval} -c {$g['varetc_path']}/filterdns.conf -d 1"); + } + mwexec("/usr/local/sbin/filterdns -p /var/run/filterdns.pid -i {$resolve_interval} -c /var/etc/filterdns.conf -d 1"); } } else { - killbypid("{$g['varrun_path']}/filterdns.pid"); - @unlink("{$g['varrun_path']}/filterdns.pid"); + killbypid('/var/run/filterdns.pid'); } /* run items scheduled for after filter configure run */ diff --git a/src/etc/inc/gwlb.inc b/src/etc/inc/gwlb.inc index a347d18da..071e79f47 100644 --- a/src/etc/inc/gwlb.inc +++ b/src/etc/inc/gwlb.inc @@ -48,20 +48,22 @@ function return_apinger_defaults() { * Creates monitoring configuration file and * adds appropriate static routes. */ -function setup_gateways_monitor() { +function setup_gateways_monitor() +{ global $config, $g; $gateways_arr = return_gateways_array(); if (!is_array($gateways_arr)) { log_error("No gateways to monitor. Apinger will not be run."); - killbypid("{$g['varrun_path']}/apinger.pid"); - @unlink("{$g['varrun_path']}/apinger.status"); + killbypid('/var/run/apinger.pid'); + @unlink('/var/run/apinger.status'); return; } $apinger_debug = ""; - if (isset($config['system']['apinger_debug'])) + if (isset($config['system']['apinger_debug'])) { $apinger_debug = "debug on"; + } $apinger_default = return_apinger_defaults(); $apingerconfig = << $_POST['timezone']) { - filter_pflog_start(true); +if ($pconfig['timezone'] <> $_POST['timezone']) { + filter_pflog_start(); } $timezonelist = array_map(