lucaspalomodevelop/core
1
0
Fork 0
mirror of https://github.com/lucaspalomodevelop/core.git synced 2026-03-16 09:34:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

api, race condition in setting json body on dynamic class

Browse Source
This commit is contained in:
Ad Schellevis 2017-04-22 11:26:43 +02:00
parent 8d3797a2ac
commit 1a16bfba0c
1 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php
View File

@ -137,23 +137,23 @@ class ApiControllerBase extends ControllerRoot
$req_c = $object_info->getMethod($callMethodName)->getNumberOfRequiredParameters();
if ($req_c > count($dispatcher->getParams())) {
$dispatchError = 'action ' . $dispatcher->getActionName() .
' expects at least '. $req_c . ' parameter(s)';
} else {
// if body is send as json data, parse to $_POST first
$dispatchError = $this->parseJsonBodyData();
}
if ($dispatchError != null) {
// send error to client
$this->response->setStatusCode(400, "Bad Request");
$this->response->setContentType('application/json', 'UTF-8');
$this->response->setJsonContent(
array('message' => $dispatchError,
'status' => 400)
);
$this->response->send();
return false;
' expects at least ' . $req_c . ' parameter(s)';
}
}
// if body is send as json data, parse to $_POST first
$dispatchError = empty($dispatchError) ? $this->parseJsonBodyData() : $dispatchError;
if ($dispatchError != null) {
// send error to client
$this->response->setStatusCode(400, "Bad Request");
$this->response->setContentType('application/json', 'UTF-8');
$this->response->setJsonContent(
array('message' => $dispatchError,
'status' => 400)
);
$this->response->send();
return false;
}
return true;
}