Firewall : Advanced - Add support for syncookies, minor validation issue allowing empty adaptive values (for https://github.com/opnsense/core/issues/5561)

This commit is contained in:
Ad Schellevis 2022-02-15 23:54:37 +01:00
parent 6a2f45af2c
commit 197f290801

View File

@ -94,7 +94,7 @@ if ($_SERVER['REQUEST_METHOD'] === 'GET') {
if (!in_array($pconfig['syncookies'], ['always', 'adaptive'])) {
$input_errors[] = sprintf(gettext("Unknown syncookie type %s.", $pconfig['syncookies']));
}
if ((empty($pconfig['syncookies_adaptstart']) && !empty($pconfig['syncookies_adaptstart'])) || (!empty($pconfig['syncookies_adaptstart']) && empty($pconfig['syncookies_adaptend']))) {
if ($pconfig['syncookies'] == 'adaptive' && (empty($pconfig['syncookies_adaptstart']) || empty($pconfig['syncookies_adaptend']))) {
$input_errors[] = gettext("Syncookie Adaptive values must be set together.");
}
if (!empty($pconfig['syncookies_adaptstart']) && !is_numericint($pconfig['syncookies_adaptstart'])) {