Firewall, validate port alias... wrong order, causing disabled snat rule.

This commit is contained in:
Ad Schellevis 2018-08-05 12:42:53 +02:00
parent a435f74707
commit 188afed620

View File

@ -98,12 +98,12 @@ class SNatRule extends Rule
}
foreach (array("sourceport", "dstport", "natport") as $fieldname) {
if (!empty($rule[$fieldname]) && Util::isAlias($rule[$fieldname])) {
$rule[$fieldname] = "$".$rule[$fieldname];
if (!Util::isAlias($rule[$fieldname], true)) {
// unable to map port
$this->log("SNAT / unable to map port ". $rule[$fieldname]. ", empty?");
$rule['disabled'] = true;
}
$rule[$fieldname] = "$".$rule[$fieldname];
}
}
if (!empty($rule['staticnatport']) || !empty($rule['nonat'])) {