From 11561ba4dace65082dd28b6e3f05723a2b90d5df Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Fri, 4 Mar 2016 15:43:26 +0100
Subject: [PATCH] make: lint a couple of shell scripts we can easily find

---
 Makefile                               | 2 ++
 src/opnsense/scripts/firmware/check.sh | 2 --
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 710a92e3f..5c7a13ff5 100644
--- a/Makefile
+++ b/Makefile
@@ -168,6 +168,8 @@ plist: force
 	@${MAKE} -C ${.CURDIR}/src plist
 
 lint: force
+	find ${.CURDIR}/src ${.CURDIR}/scripts \
+	    -name "*.sh" -type f -print0 | xargs -0 -n1 sh -n
 	find ${.CURDIR}/src ${.CURDIR}/lang/dynamic/helpers \
 	    ! -name "*.xml" ! -name "*.xml.sample" ! -name "*.eot" \
 	    ! -name "*.svg" ! -name "*.woff" ! -name "*.woff2" \
diff --git a/src/opnsense/scripts/firmware/check.sh b/src/opnsense/scripts/firmware/check.sh
index 6e5d0cca4..219097ee6 100755
--- a/src/opnsense/scripts/firmware/check.sh
+++ b/src/opnsense/scripts/firmware/check.sh
@@ -226,6 +226,4 @@ if [ "$pkg_running" == "" ]; then
       last_check=`date`
       # Write our json structure to disk
       echo "{\"connection\":\"$connection\",\"repository\":\"$repository\",\"last_check\":\"$last_check\",\"updates\":\"$updates\",\"download_size\":\"$download_size\",\"extra_space_required\":\"$required_space\",\"new_packages\":[$packages_new],\"reinstall_packages\":[$packages_reinstall],\"upgrade_packages\":[$packages_upgraded],\"upgrade_needs_reboot\":\"$upgrade_needs_reboot\"}"
-else
-  # pkg is already running, quitting
 fi