firmware: simplify for previous #4906

This commit is contained in:
Franco Fichtner 2021-04-09 14:28:05 +02:00
parent 35217ba0d1
commit 0f3fcd2b05

View File

@ -92,7 +92,6 @@ class FirmwareController extends ApiControllerBase
$active_size = '';
$active_status = '';
$backend = new Backend();
$target = null;
$this->sessionClose(); // long running action, close session
@ -105,10 +104,6 @@ class FirmwareController extends ApiControllerBase
if ($response != null && $response['product_check'] != null) {
$response = $response['product_check'];
if ($response['product_id'] != $response['product_target']) {
$target = $response['product_target'];
}
$download_size = !empty($response['download_size']) ? $response['download_size'] : 0;
$upgrade_size = 0;
@ -271,8 +266,8 @@ class FirmwareController extends ApiControllerBase
} elseif (array_key_exists('repository', $response) && $response['repository'] == 'unsigned') {
$response['status_msg'] = gettext('The repository has no fingerprint.');
$response['status'] = 'error';
} elseif (array_key_exists('repository', $response) && $response['repository'] == 'incomplete' && !empty($target)) {
$response['status_msg'] = sprintf(gettext('The release type "%s" is not available on this repository.'), $target);
} elseif (array_key_exists('repository', $response) && $response['repository'] == 'incomplete') {
$response['status_msg'] = sprintf(gettext('The release type "%s" is not available on this repository.'), $response['product_target']);
$response['status'] = 'error';
} elseif (array_key_exists('repository', $response) && $response['repository'] != 'ok') {
$response['status_msg'] = gettext('Could not find the repository on the selected mirror.');