From 0e7097cfb1f2bd19c402d3178d7a0259be6ff91a Mon Sep 17 00:00:00 2001 From: Franco Fichtner Date: Tue, 6 Jul 2021 12:31:14 +0200 Subject: [PATCH] system: isvalidpid() is not required for a single killbypid() --- src/etc/inc/system.inc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/etc/inc/system.inc b/src/etc/inc/system.inc index d447a5503..01cc541b8 100644 --- a/src/etc/inc/system.inc +++ b/src/etc/inc/system.inc @@ -678,9 +678,7 @@ EOD; mwexecf("/usr/local/opnsense/scripts/syslog/generate_certs"); if (!empty($config['syslog']['disable_clog'])) { // non legacy mode - if (isvalidpid('/var/run/syslog.pid')) { - killbypid('/var/run/syslog.pid', 'TERM', true); - } + killbypid('/var/run/syslog.pid', 'TERM', true); if (!$restart && isvalidpid('/var/run/syslog-ng.pid')) { mwexecf("/usr/local/sbin/syslog-ng-ctl reload"); } else {