lucaspalomodevelop/core
1
0
Fork 0
mirror of https://github.com/lucaspalomodevelop/core.git synced 2026-03-14 00:24:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Firewall: Automation: Filter - add max (states) option for https://github.com/opnsense/core/issues/8143

Browse Source
This commit is contained in:
Ad Schellevis 2024-12-24 17:17:28 +01:00
parent 207d51de55
commit 0d9550b912
3 changed files with 22 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
View File

@ -154,6 +154,16 @@
<help>State Timeout in seconds (TCP only)</help>
<advanced>true</advanced>
</field>
<field>
<id>rule.max</id>
<label>Max states</label>
<type>text</type>
<help>
Limits the number of concurrent states the rule may create.
When this limit is reached, further packets that would create state are dropped until existing states time out.
</help>
<advanced>true</advanced>
</field>
<field>
<id>rule.max-src-nodes</id>
<label>Max source nodes</label>

14
src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.php
View File

@ -118,11 +118,15 @@ class Filter extends BaseModel
$rule->interfacenot->__reference
));
}
if ($rule->statetype == 'none' && !empty((string)$rule->statetimeout)) {
$messages->appendMessage(new Message(
gettext("You cannot specify the state timeout (advanced option) if statetype is none."),
$rule->statetimeout->__reference
));
if ($rule->statetype == 'none') {
foreach (['statetimeout', 'max', 'max-src-states', 'max-src-nodes'] as $fieldname) {
if (!empty((string)$rule->$fieldname)) {
$messages->appendMessage(new Message(
gettext("Invalid option when statetype is none."),
$rule->$fieldname->__reference
));
}
}
}
if (!in_array($rule->protocol, ['TCP', 'TCP/UDP']) && !empty((string)$rule->statetimeout)) {
$messages->appendMessage(new Message(

3
src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
View File

@ -148,6 +148,9 @@
<max-src-states type="IntegerField">
<MinimumValue>1</MinimumValue>
</max-src-states>
<max type="IntegerField">
<MinimumValue>1</MinimumValue>
</max>
<categories type="ModelRelationField">
<Model>
<rulesets>