From 0a0e5ee74715befca6d9c3d3db228ab3c4928f08 Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Tue, 20 Nov 2018 20:23:48 +0100 Subject: [PATCH] OpenVPN export, regression in configuredSetttings(), use collected presets when server settings aren't found. for https://github.com/opnsense/core/issues/2787 --- .../app/controllers/OPNsense/OpenVPN/Api/ExportController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/opnsense/mvc/app/controllers/OPNsense/OpenVPN/Api/ExportController.php b/src/opnsense/mvc/app/controllers/OPNsense/OpenVPN/Api/ExportController.php index 85cf6956d..7c6e5a9c3 100644 --- a/src/opnsense/mvc/app/controllers/OPNsense/OpenVPN/Api/ExportController.php +++ b/src/opnsense/mvc/app/controllers/OPNsense/OpenVPN/Api/ExportController.php @@ -151,7 +151,7 @@ class ExportController extends ApiControllerBase foreach ($serverModel->iterateItems() as $field => $value) { if (!empty((string)$value)) { $result[$field] = (string)$value; - } else { + } elseif (!empty((string)$server->$field) || !isset($result[$field])) { $result[$field] = (string)$server->$field; } }