From 062ad3f82ce5b1146a3d9aae7fa8ca72858ea1e3 Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Mon, 21 May 2018 10:18:06 +0000
Subject: [PATCH] intrusion detection: optional fast log to syslog

Change syslog to be always on but use the syslog checkbox
to decide whether alert logging is forwarded or not.

Discussed with: @adschellevis
---
 .../app/controllers/OPNsense/IDS/forms/generalSettings.xml  | 6 ++++++
 src/opnsense/mvc/app/models/OPNsense/IDS/IDS.xml            | 4 ++++
 src/opnsense/service/templates/OPNsense/IDS/suricata.yaml   | 3 ++-
 3 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/src/opnsense/mvc/app/controllers/OPNsense/IDS/forms/generalSettings.xml b/src/opnsense/mvc/app/controllers/OPNsense/IDS/forms/generalSettings.xml
index d3b86253d..a8945463e 100644
--- a/src/opnsense/mvc/app/controllers/OPNsense/IDS/forms/generalSettings.xml
+++ b/src/opnsense/mvc/app/controllers/OPNsense/IDS/forms/generalSettings.xml
@@ -17,6 +17,12 @@
         <type>checkbox</type>
         <help><![CDATA[Enable promiscuous mode, for certain setups (like IPS with vlans), this is required to actually capture data on the physical interface.]]></help>
     </field>
+    <field>
+        <id>ids.general.syslog</id>
+        <label>Enable syslog alerts</label>
+        <type>checkbox</type>
+        <help><![CDATA[Send alerts to system log in fast log format. This will not change the alert logging used by the product itself.]]></help>
+    </field>
     <field>
         <id>ids.general.MPMAlgo</id>
         <label>Pattern matcher</label>
diff --git a/src/opnsense/mvc/app/models/OPNsense/IDS/IDS.xml b/src/opnsense/mvc/app/models/OPNsense/IDS/IDS.xml
index 0fbe11a81..928492af6 100644
--- a/src/opnsense/mvc/app/models/OPNsense/IDS/IDS.xml
+++ b/src/opnsense/mvc/app/models/OPNsense/IDS/IDS.xml
@@ -172,6 +172,10 @@
               </OptionValues>
               <ValidationMessage>Please select a valid pattern matcher algorithm</ValidationMessage>
             </MPMAlgo>
+            <syslog type="BooleanField">
+                <default>0</default>
+                <Required>Y</Required>
+            </syslog>
             <LogPayload type="BooleanField">
                 <default>0</default>
                 <Required>Y</Required>
diff --git a/src/opnsense/service/templates/OPNsense/IDS/suricata.yaml b/src/opnsense/service/templates/OPNsense/IDS/suricata.yaml
index d4afb66a0..4026da5b3 100644
--- a/src/opnsense/service/templates/OPNsense/IDS/suricata.yaml
+++ b/src/opnsense/service/templates/OPNsense/IDS/suricata.yaml
@@ -239,7 +239,8 @@ outputs:
 
   # a line based alerts log similar to fast.log into syslog
   - syslog:
-      enabled: yes
+      enabled: {% if helpers.exists('OPNsense.IDS.general.syslog') and OPNsense.IDS.general.syslog|default('0') == '0' %}no{% else %}yes{% endif %}
+
       # reported identity to syslog. If ommited the program name (usually
       # suricata) will be used.
       #identity: "suricata"