From 054a7ee8348fda7b49c3ce32150ed6ab13606d53 Mon Sep 17 00:00:00 2001
From: Ad Schellevis <ad@opnsense.org>
Date: Fri, 7 Oct 2022 11:05:08 +0200
Subject: [PATCH] Interfaces: Other Types: VLAN - setItemAction() loop variable
 issue, overlapping with requested node leading to faulty validation results.

---
 .../OPNsense/Interfaces/Api/VlanSettingsController.php        | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/VlanSettingsController.php b/src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/VlanSettingsController.php
index d7f39ec0a..70b2a234f 100644
--- a/src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/VlanSettingsController.php
+++ b/src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/VlanSettingsController.php
@@ -91,8 +91,8 @@ class VlanSettingsController extends ApiMutableModelControllerBase
         $old_vlanif = $node != null ? (string)$node->vlanif : null;
         $new_vlanif = $this->generateVlanIfName($node);
         $children = 0;
-        foreach ($this->getModel()->vlan->iterateItems() as $node) {
-            if ((string)$node->if == $old_vlanif) {
+        foreach ($this->getModel()->vlan->iterateItems() as $cnode) {
+            if ((string)$cnode->if == $old_vlanif) {
                 $children++;
             }
         }