From 0200f79a198c56ba73269423a48fe2b0920cb1a6 Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Sat, 3 Jun 2023 12:30:15 +0200
Subject: [PATCH] system: dealing with "sleep 60" and signals in scripts is
 hard...

PR: https://forum.opnsense.org/index.php?topic=34241.0
---
 src/etc/inc/rrd.inc | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/etc/inc/rrd.inc b/src/etc/inc/rrd.inc
index ede6aa5b4..946dea4c8 100644
--- a/src/etc/inc/rrd.inc
+++ b/src/etc/inc/rrd.inc
@@ -553,15 +553,16 @@ function rrd_configure($verbose = false, $bootup = false)
 
 EOD;
 
-        $rrdupdatesh .= "sleep 60\n";
+        $rrdupdatesh .= "\n";
+        $rrdupdatesh .= "     for UNUSED in \$(seq 1 60); do sleep 1; done\n";
         $rrdupdatesh .= "done\n";
 
         /* write the rrd update script */
         $updaterrdscript = '/var/db/rrd/updaterrd.sh';
-        $fd = fopen("$updaterrdscript", "w");
-        fwrite($fd, "$rrdupdatesh");
+        $fd = fopen($updaterrdscript, 'w');
+        fwrite($fd, $rrdupdatesh);
         fclose($fd);
-        chmod($updaterrdscrip, 0755);
+        chmod($updaterrdscript, 0755);
 
         /* start traffic collector */
         mwexecf('/usr/sbin/daemon -f -p %s %s', ['/var/run/updaterrd.pid', $updaterrdscript]);