From 001c382c51b617110a0b00990bd418c25e4ae918 Mon Sep 17 00:00:00 2001 From: Franco Fichtner Date: Fri, 1 Sep 2023 08:51:50 +0200 Subject: [PATCH] mvc: one small change Same goes for Required=N but since that is used 251 times it's probably better to skip this. --- Makefile | 3 +++ src/opnsense/mvc/app/models/OPNsense/Monit/Monit.xml | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 2ae1c2f45..9d389c795 100644 --- a/Makefile +++ b/Makefile @@ -378,6 +378,9 @@ lint-model: (xmllint $${MODEL} --xpath '//*[@type and not(@type="ArrayField") and BlankDesc and Multiple="Y"]' 2> /dev/null | grep '^<' || true) | while read LINE; do \ echo "$${MODEL}: $${LINE} blank description not applicable on multiple field"; \ done; \ + (xmllint $${MODEL} --xpath '//*[@type and not(@type="ArrayField") and Multiple="N"]' 2> /dev/null | grep '^<' || true) | while read LINE; do \ + echo "$${MODEL}: $${LINE} Multiple=N is the default"; \ + done; \ (xmllint $${MODEL} --xpath '//*[@type and not(@type="ArrayField") and OptionValues[default[not(@value)] or multiple[not(@value)] or required[not(@value)]]]' 2> /dev/null | grep '^<' || true) | while read LINE; do \ echo "$${MODEL}: $${LINE} option element default/multiple/required without value attribute"; \ done; \ diff --git a/src/opnsense/mvc/app/models/OPNsense/Monit/Monit.xml b/src/opnsense/mvc/app/models/OPNsense/Monit/Monit.xml index 32bb7d09e..b2c0e5604 100644 --- a/src/opnsense/mvc/app/models/OPNsense/Monit/Monit.xml +++ b/src/opnsense/mvc/app/models/OPNsense/Monit/Monit.xml @@ -241,7 +241,6 @@ N - N Y /^(?!0).*$/